Skip to content

chore(agentic-ci): declare pandas as direct dep of data-designer-engine#705

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
agentic-ci/chore/dependencies-20260526-engine-pandas
Open

chore(agentic-ci): declare pandas as direct dep of data-designer-engine#705
github-actions[bot] wants to merge 1 commit into
mainfrom
agentic-ci/chore/dependencies-20260526-engine-pandas

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Declares pandas as a direct dependency of data-designer-engine.

Why

Per AGENTS.md and the dependencies-suite audit (2026-05-26):
data-designer-engine imports pandas directly in ~30 source files
(e.g. engine/analysis/column_profilers/base.py,
engine/analysis/column_statistics.py,
engine/dataset_builders/dataset_builder.py,
engine/analysis/utils/column_statistics_calculations.py,
engine/analysis/dataset_profiler.py) but only data-designer-config
declared it. The engine relied on transitive resolution through the
config package, which works for the monorepo install but is fragile if
data-designer-engine is ever installed standalone, and it bypasses
the "each package declares what it directly imports" contract.

This is the same class of fix as PR #676 (numpy for the same
package).

What changed

A single line — "pandas>=2.3.3,<3", — added to the
[tool.hatch.metadata.hooks.uv-dynamic-versioning].dependencies list
in packages/data-designer-engine/pyproject.toml, in alphabetical
position between numpy and python-multipart. The specifier is
copied verbatim from packages/data-designer-config/pyproject.toml
where pandas>=2.3.3,<3 is already declared, so no version-range
reconciliation is required.

Tests

  • make install-dev resolved the lockfile cleanly (only the engine's
    own version metadata changed in uv.lock).
  • make test-engine — 2194 passed in 42.43s.

Provenance

Generated by the agentic-ci dependencies suite (daily run,
2026-05-26). Finding id ad8356793082, fix confidence 0.85, severity
high (heavy import bypassing the declared-deps contract).

@github-actions github-actions Bot requested a review from a team as a code owner May 26, 2026 09:26
@github-actions github-actions Bot added agentic-ci Created by agentic-ci automation agentic-ci/dependencies Agentic CI - dependencies suite labels May 26, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

Declares pandas as a direct dependency of data-designer-engine to satisfy the monorepo contract that each package must list every library it directly imports. The version specifier (>=2.3.3,<3) is copied verbatim from data-designer-config/pyproject.toml, so no version-range reconciliation is needed.

  • Single-line addition to the [tool.hatch.metadata.hooks.uv-dynamic-versioning].dependencies list in packages/data-designer-engine/pyproject.toml, inserted alphabetically between numpy and python-multipart.
  • Mirrors the same class of fix applied to numpy in PR chore(agentic-ci): declare numpy as direct dep of data-designer-engine #676 and eliminates reliance on transitive resolution through data-designer-config for standalone installs.

Confidence Score: 5/5

Safe to merge — adds one dependency line with a version specifier that is already pinned and tested in a sibling package.

The change is a single-line addition to a dependency list. The specifier pandas>=2.3.3,<3 is copied verbatim from data-designer-config, so no new version range was invented, and the lockfile was verified clean against 2194 passing tests.

No files require special attention.

Important Files Changed

Filename Overview
packages/data-designer-engine/pyproject.toml Adds pandas>=2.3.3,<3 as a direct dependency of data-designer-engine; version specifier matches data-designer-config exactly and placement is alphabetically correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[data-designer-engine] -->|direct dep, declared| B[data-designer-config]
    A -->|direct dep, NOW declared| C[pandas>=2.3.3,<3]
    B -->|direct dep, declared| C
    A -->|direct dep, declared| D[numpy>=1.23.5,<3]
    B -->|direct dep, declared| D

    style C fill:#90EE90,stroke:#228B22
Loading

Reviews (1): Last reviewed commit: "chore(agentic-ci): declare pandas as dir..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-ci/dependencies Agentic CI - dependencies suite agentic-ci Created by agentic-ci automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants